Quickfix Bug #7384

[DavidLP]

Description:

The used python library spotipy version 2.4.4 from https://github.com/happyleavesaoc/spotipy/archive/544614f4b1d508201d363e84e871f86c90aa26b2.zip returns for spotipy.Spotify(auth=...).devices() either a python dict or None. The None case was not treated leading to a crash.

Related issue (if applicable): fixes #7384

Example entry for configuration.yaml (if applicable):

   media_player:
    - platform: spotify
      client_id: XXXXXXXXXXXXXXXXXXXXXXXXXXXX
      client_secret: XXXXXXXXXXXXXXXXXXXXXXXXX

Checklist:

If the code does not interact with devices:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass
• Local installation works after bug fix

[mention-bot]

@DavidLP, thanks for your PR! By analyzing the history of the files in this pull request, we identified @happyleavesaoc, @fabaff and @abmantis to be potential reviewers.

[abmantis]

You say that the None case was not treated, but you added exception handling. Was the exception that was not catch before?

[DavidLP]

The exception occured when using None like a dict. None does not have a get method.

[abmantis]

Isn't it better to just do a if self._player.devices() is None: .... instead of the try?

[DavidLP]

It is not guaranteed that repeated calls to self._player.devices() will return the same. I actually observed that the first call returned a dict, but the second one None. One could of cause save the self._player.devices() return value in a variable, but I think that the exception handling here is fine.

[abmantis]

Ok. Looks good to me then!

[DavidLP]

At another point the same unsafe API call is done, that I have to fix first. So please do not merge yet.

[DavidLP]

I do not have any issues after this fix. Without this fix spotify plugin cannot be used right now. Thus I recomment merging and releasing in next bugfix releae.