Zwave: Apply refresh_node workaround on 1st instance only#7579
Merged
Conversation
|
@andrey-git, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ChristianKuehnel, @turbokongen and @armills to be potential reviewers. |
emlove
approved these changes
May 15, 2017
Contributor
emlove
left a comment
emlove
left a comment
There was a problem hiding this comment.
Lets add a test that the node isn't refreshed for instance=2. Otherwise LGTM.
emlove
approved these changes
May 21, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Apply refresh_node workaround on 1st instance only.
The buggy device behavior is sending update on main instance (1) when another instance changed.
Thus it is enough to apply workaround on instance 1 only.
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass