Skip to content

Add SSL support to NZBGet sensor#7553

Merged
fabaff merged 1 commit into
home-assistant:devfrom
tboyce021:patch-1
May 11, 2017
Merged

Add SSL support to NZBGet sensor#7553
fabaff merged 1 commit into
home-assistant:devfrom
tboyce021:patch-1

Conversation

@tboyce021
Copy link
Copy Markdown
Contributor

@tboyce021 tboyce021 commented May 11, 2017

Description:

Adds support for SSL hosts to the NZBGet sensor.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2616

Example entry for configuration.yaml (if applicable):

sensor:
  platform: nzbget
  host: nzbget.domain.com
  port: 443
  ssl: true
  monitored_variables:
    - download_rate
    - download_size

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link
Copy Markdown

@tboyce021, thanks for your PR! By analyzing the history of the files in this pull request, we identified @justyns, @fabaff and @jabesq to be potential reviewers.

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff merged commit 0e24605 into home-assistant:dev May 11, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants