Skip to content

Add ssh-rsa as acceptable an host key algorithm#74684

Merged
frenck merged 1 commit into
home-assistant:devfrom
siyuan-nz:fix-unifi_direct
Jul 8, 2022
Merged

Add ssh-rsa as acceptable an host key algorithm#74684
frenck merged 1 commit into
home-assistant:devfrom
siyuan-nz:fix-unifi_direct

Conversation

@siyuan-nz
Copy link
Copy Markdown

Breaking change

Proposed change

Specify the HostKeyAlgorithms option with ssh-rsa so that unifi_direct can connect to UniFi AP.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant

This comment was marked as resolved.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @siyuan-nz,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @siyuan-nz 👍

@frenck frenck merged commit 06530eb into home-assistant:dev Jul 8, 2022
@balloob balloob mentioned this pull request Jul 8, 2022
gautamg795 added a commit to gautamg795/HomeAssistantUnifiDirect that referenced this pull request Jul 9, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unifi_direct fails to connect

4 participants