Skip to content

Update to pyunifi 2.12#7468

Merged
balloob merged 2 commits into
home-assistant:devfrom
finish06:pyunifi_improved_exception_handling
May 7, 2017
Merged

Update to pyunifi 2.12#7468
balloob merged 2 commits into
home-assistant:devfrom
finish06:pyunifi_improved_exception_handling

Conversation

@finish06
Copy link
Copy Markdown
Contributor

@finish06 finish06 commented May 6, 2017

Description:

Attempted to add improved exception handling within pyunifi. The pyunifi package will now attempt to log in if an access error is encountered. Additionally, the package will try 5 times for the unifi server to be brought back up in 1 minute intervals prior to giving up.

If the end user decides to not use a verified ssl certificate, the pyunifi package will now spit out warnings every time it sends a request as was requested by @balloob.

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

No changes

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link
Copy Markdown

@finish06, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kk7ds, @fabaff and @kellerza to be potential reviewers.

@balloob
Copy link
Copy Markdown
Member

balloob commented May 7, 2017

If the end user decides to not use a verified ssl certificate, the pyunifi package will now spit out warnings every time it sends a request

Isn't this avoidable by setting verify=False when making a request ?

@balloob balloob merged commit 41212b9 into home-assistant:dev May 7, 2017
@balloob
Copy link
Copy Markdown
Member

balloob commented May 7, 2017

Cherry-picked for 0.44.1

balloob pushed a commit that referenced this pull request May 7, 2017
* Update to pyunifi 2.12

* Update requirements_all.txt
@balloob balloob mentioned this pull request May 7, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants