Make Store a generic class#74617
Merged
Merged
Conversation
probot-home-assistant
Bot
added
code-quality
core
small-pr
23 tasks
frenck
added
the
smash
|
|
||
| if isinstance(data, dict): | ||
| for area in data["areas"]: | ||
| assert area["name"] is not None and area["id"] is not None |
Member
There was a problem hiding this comment.
Maybe make a TypedDict for data?
Contributor
Author
There was a problem hiding this comment.
area["id"] could still be None so I'm not sure it would help a great deal in this case.
Member
|
Are there more things to update than the 20 errors found by CI? |
epenet
force-pushed
the
make-store-generic
branch
from
36ab1cf to
bd43bc5
Compare
epenet
commented
Jul 7, 2022
epenet
requested review from
Adminiuga,
Danielhiversen,
allenporter,
andrewsayre,
balloob,
dmulcahey and
ludeeus
as code owners
Contributor
Author
I think that's it. It looked daunting but I think it works... 👍 |
MartinHjelmare
approved these changes
Jul 7, 2022
Member
|
Should we highlight this in a dev blog? |
5 tasks
Contributor
Author
|
PR for dev blog: home-assistant/developers.home-assistant#1386 |
epenet
force-pushed
the
make-store-generic
branch
from
5d3fd14 to
8b4cce6
Compare
Contributor
Author
|
Rebased to pickup new integration: #74243 |
allenporter
approved these changes
Jul 8, 2022
Contributor
allenporter
left a comment
allenporter
left a comment
There was a problem hiding this comment.
Looks good for nest. Thank you, this makes Store a lot more usable to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Make Store a generic
As discussed with @MartinHjelmare in #74603 (comment)
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: