Skip to content

Try to request current_location Automatic scope#7447

Merged
emlove merged 1 commit into
home-assistant:devfrom
emlove:automatic-current-location
May 10, 2017
Merged

Try to request current_location Automatic scope#7447
emlove merged 1 commit into
home-assistant:devfrom
emlove:automatic-current-location

Conversation

@emlove
Copy link
Copy Markdown
Contributor

@emlove emlove commented May 4, 2017

Description:

This PR makes Home Assistant attempt to register with scope:current_location, and falls back to the previous scope if it's not available.

WIP because I haven't been able to test the successful branch yet. Still waiting on approval from Automatic.

home-assistant/home-assistant.io#2570

@mention-bot
Copy link
Copy Markdown

@armills, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Teagan42 and @pvizeli to be potential reviewers.

Copy link
Copy Markdown
Contributor

@Teagan42 Teagan42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me - other option was to add optional configuration value.

@Teagan42
Copy link
Copy Markdown
Contributor

Teagan42 commented May 4, 2017

Might want to update the docs

@emlove
Copy link
Copy Markdown
Contributor Author

emlove commented May 5, 2017

Sounds good. I'll get a doc update in today.

@emlove emlove changed the title [WIP] Try to request current_location Automatic scope Try to request current_location Automatic scope May 10, 2017
@emlove
Copy link
Copy Markdown
Contributor Author

emlove commented May 10, 2017

Got my auth from Automatic. Works as expected. 🎉

@emlove emlove merged commit 8c90fd1 into home-assistant:dev May 10, 2017
@emlove emlove deleted the automatic-current-location branch May 10, 2017 12:44
@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants