Log out of TP-Link router after devices are recorded.#7289
Merged
Conversation
|
@jminardi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mKeRix, @fabaff and @michaelarnauts to be potential reviewers. |
Contributor
houndci-bot
reviewed
Apr 25, 2017
| 'form=logout').format(self.host, self.stok) | ||
| referer = 'http://{}/webpages/index.html'.format(self.host) | ||
|
|
||
| response = requests.post(url, |
There was a problem hiding this comment.
local variable 'response' is assigned to but never used
Member
|
Looks not bad. Please address comments from travis |
jminardi
added a commit
to jminardi/home-assistant.github.io
that referenced
this pull request
May 1, 2017
jminardi
added a commit
to jminardi/home-assistant.github.io
that referenced
this pull request
May 1, 2017
jminardi
added a commit
to jminardi/home-assistant.github.io
that referenced
this pull request
May 1, 2017
Contributor
|
Use a comma instead of a percent sign. Don't put the message in a string. |
fabaff
pushed a commit
to home-assistant/home-assistant.io
that referenced
this pull request
May 1, 2017
* Update device_tracker.tplink.markdown Depends on home-assistant/core#7289 * Make a real sentence
Contributor
Author
|
Ok, finally got the tests to pass, I think this is good to go now. |
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
While investigating #7262 I discovered my issue was that I needed to use the "encrypted password" as described in the TP-Link docs (Even though I don't have the model listed there). Having the error message here would have helped me see that sooner.
I also updated the
Tplink3DeviceScannerclass to log out of the admin interface after it gets the info it needs. The allows someone else to log into the interface without waiting minutes for the timeout.Related issue (if applicable): fixes #7262
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass