Skip to content

Bump laundrify_aio to v1.1.2#72605

Merged
thecode merged 1 commit intohome-assistant:devfrom
laundrify:fix/bump-laundrify
May 27, 2022
Merged

Bump laundrify_aio to v1.1.2#72605
thecode merged 1 commit intohome-assistant:devfrom
laundrify:fix/bump-laundrify

Conversation

@xLarry
Copy link
Copy Markdown
Contributor

@xLarry xLarry commented May 27, 2022

Proposed change

Bump laundrify_aio to v1.1.2

The laundrify integration will be released in the upcoming 2022.6 release (see #65090). While testing the current beta release it turned out that the laundrify_aio dependency has accidentally been published pointing to the test environment.

It would be great if this could be merged in the current beta cycle.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For others who review it:
The issue is not visible in the source code on GitHub, can only be seen in the released PyPI packages.

1.1.1 API host is https://test.laundrify.de and 1.1.2 is https://api.laundrify.de

@thecode thecode added this to the 2022.6.0 milestone May 27, 2022
@thecode thecode merged commit 2a1405c into home-assistant:dev May 27, 2022
@thecode
Copy link
Copy Markdown
Member

thecode commented May 27, 2022

@xLarry for future releases and to avoid mistakes it is better to create a tag upon release:
https://git-scm.com/book/en/v2/Git-Basics-Tagging

An example of a PR for a dependency bump with tagged releases: #72576

It also allows to add a diff between released tags which makes reviewing easier.

Thanks.

@xLarry
Copy link
Copy Markdown
Contributor Author

xLarry commented May 27, 2022

Many thanks for your instant review and helpful hints, @thecode.

I will keep in mind to tag future releases of the laundrify_aio package :)

balloob pushed a commit that referenced this pull request May 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants