Skip to content

Use My Home Assistant for OAuth2 redirect callbacks#72449

Merged
balloob merged 2 commits intodevfrom
frenck-2022-1090
May 25, 2022
Merged

Use My Home Assistant for OAuth2 redirect callbacks#72449
balloob merged 2 commits intodevfrom
frenck-2022-1090

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented May 24, 2022

Breaking change

Home Assistant will now use My Home Assistant redirecting OAuth2 callback over. If you need to re-authenticate with an exiting OAuth2 application in the future, you might need to adjust the external application configuration. Please check the documentation of the specific integration on how to configure this.

Proposed change

Use https://my.home-assistant.io/redirect/callback as the redirect URI when the my integration is enabled.

Needs:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added breaking-change core small-pr PRs with less than 30 lines. labels May 24, 2022
@frenck frenck marked this pull request as ready for review May 24, 2022 17:43
@frenck frenck requested a review from a team as a code owner May 24, 2022 17:43
@balloob balloob merged commit 38ad1ef into dev May 25, 2022
@balloob balloob deleted the frenck-2022-1090 branch May 25, 2022 02:00
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants