Chunk large logbook queries and add an end_time to the api so we stop sending events#72351
Merged
balloob merged 18 commits intohome-assistant:devfrom May 23, 2022
Merged
Chunk large logbook queries and add an end_time to the api so we stop sending events#72351balloob merged 18 commits intohome-assistant:devfrom
balloob merged 18 commits intohome-assistant:devfrom
Conversation
- I forget to mark this as frozen
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Member
Author
|
Need to run performance stats again to make sure this is no impact. Can't imagine there would be, but I need to do it anyways to revalidate the REST api and original websocket api has not regressed. |
9 tasks
Member
Author
|
Test failed because the CI runner is too slow 👎 |
Member
Author
|
I ended up switching to async_fire_time_changed. It is good enough for the test. Better to be reliable than perfect. |
balloob
approved these changes
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend PR home-assistant/frontend#12753
Proposed change
end_timein the past (useful with big queries) or future (for when to cut off streaming)Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: