Skip to content

Allow zwave_js/network_status WS API to accept device or entry ID#72205

Merged
raman325 merged 4 commits intohome-assistant:devfrom
raman325:device_or_entry_id
May 25, 2022
Merged

Allow zwave_js/network_status WS API to accept device or entry ID#72205
raman325 merged 4 commits intohome-assistant:devfrom
raman325:device_or_entry_id

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented May 19, 2022

Proposed change

Addresses home-assistant/frontend#12658 (comment) in conjunction with the associated frontend PR home-assistant/frontend#12735

Additional context: There are places in the frontend where we call this API from the context of the config entry, and places where we call it from the context of a device. Accepting both just lightens the load on the frontend by making the core do the necessary resolution

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare
Copy link
Copy Markdown
Member

There's a merge conflict.

@raman325 raman325 force-pushed the device_or_entry_id branch from 297cda4 to 74825c2 Compare May 25, 2022 16:37
@raman325 raman325 force-pushed the device_or_entry_id branch from 74825c2 to e236e36 Compare May 25, 2022 16:39
@zsarnett
Copy link
Copy Markdown
Contributor

Frontend PR is Approved

@raman325
Copy link
Copy Markdown
Contributor Author

will merge when tests pass

@raman325 raman325 merged commit 9b40de1 into home-assistant:dev May 25, 2022
@raman325 raman325 deleted the device_or_entry_id branch May 25, 2022 16:49
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants