Allow zwave_js/network_status WS API to accept device or entry ID#72205
Merged
raman325 merged 4 commits intohome-assistant:devfrom May 25, 2022
Merged
Allow zwave_js/network_status WS API to accept device or entry ID#72205raman325 merged 4 commits intohome-assistant:devfrom
raman325 merged 4 commits intohome-assistant:devfrom
Conversation
|
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( |
9 tasks
MartinHjelmare
approved these changes
May 24, 2022
Member
|
There's a merge conflict. |
MartinHjelmare
approved these changes
May 24, 2022
297cda4 to
74825c2
Compare
74825c2 to
e236e36
Compare
Contributor
|
Frontend PR is Approved |
Contributor
Author
|
will merge when tests pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Addresses home-assistant/frontend#12658 (comment) in conjunction with the associated frontend PR home-assistant/frontend#12735
Additional context: There are places in the frontend where we call this API from the context of the config entry, and places where we call it from the context of a device. Accepting both just lightens the load on the frontend by making the core do the necessary resolution
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: