Skip to content

Add yolink binary sensor#72000

Merged
MartinHjelmare merged 3 commits intohome-assistant:devfrom
YoSmart-Inc:yolink-feature-binarysensor
May 19, 2022
Merged

Add yolink binary sensor#72000
MartinHjelmare merged 3 commits intohome-assistant:devfrom
YoSmart-Inc:yolink-feature-binarysensor

Conversation

@matrixd2
Copy link
Copy Markdown
Contributor

@matrixd2 matrixd2 commented May 17, 2022

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @YoSmart-Inc, mind taking a look at this pull request as it has been labeled with an integration (yolink) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Comment thread homeassistant/components/yolink/binary_sensor.py Outdated
Comment thread homeassistant/components/yolink/binary_sensor.py Outdated
@matrixd2 matrixd2 requested a review from MartinHjelmare May 19, 2022 13:36
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Please link a docs PR which updates the docs page front matter, ha_platforms and ha_category.

@MartinHjelmare MartinHjelmare merged commit 1e1016a into home-assistant:dev May 19, 2022
0bmay pushed a commit to 0bmay/home-assistant-core that referenced this pull request May 19, 2022
* Add binary sensor platform

* Add untest file to .coveragerc

* change attr default
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants