Skip to content

Exclude last_changed when same as last_updated for history websocket api#71886

Merged
balloob merged 1 commit intohome-assistant:devfrom
bdraco:history_ws_protocol_mirror_ws_entities
May 15, 2022
Merged

Exclude last_changed when same as last_updated for history websocket api#71886
balloob merged 1 commit intohome-assistant:devfrom
bdraco:history_ws_protocol_mirror_ws_entities

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented May 15, 2022

Proposed change

Suggested here #71843 (review)

  • The last_changed (lc) field is no longer sent
    when its the same as the last_updated (lu) field

Not a breaking change since the history websocket api is only in dev

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

- The last_changed (lc) field is no longer sent
  when its the same as the last_updated (lu) field
@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (history) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco marked this pull request as draft May 15, 2022 04:18
@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 15, 2022

Works great.

Updated the frontend PR as well home-assistant/frontend#12662

@balloob balloob merged commit 65f44bd into home-assistant:dev May 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants