Skip to content

Streamline setup of deCONZ binary sensor platform#71820

Merged
frenck merged 4 commits intohome-assistant:devfrom
Kane610:deconz-streamline_binary_sensor_setup
May 16, 2022
Merged

Streamline setup of deCONZ binary sensor platform#71820
frenck merged 4 commits intohome-assistant:devfrom
Kane610:deconz-streamline_binary_sensor_setup

Conversation

@Kane610
Copy link
Copy Markdown
Member

@Kane610 Kane610 commented May 13, 2022

Breaking change

Proposed change

Added mechanism to manage ignoring devices and load them when using device_refresh service.
Changes except for binary_sensor and gateway are just boilerplate stuff adding the evaluate_add_device mechanism and some variable renames.

Utilise the improvements from refactoring pydeconz to stream line platform setup.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Kane610 Kane610 force-pushed the deconz-streamline_binary_sensor_setup branch from e31079f to f1f3684 Compare May 15, 2022 16:36
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label May 16, 2022
@Kane610 Kane610 force-pushed the deconz-streamline_binary_sensor_setup branch from 529a895 to cb64cb8 Compare May 16, 2022 21:31
@Kane610 Kane610 requested a review from frenck May 16, 2022 21:32
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Kane610 👍

@frenck frenck merged commit 007c6d2 into home-assistant:dev May 16, 2022
@Kane610 Kane610 deleted the deconz-streamline_binary_sensor_setup branch May 17, 2022 05:43
@Kane610
Copy link
Copy Markdown
Member Author

Kane610 commented May 17, 2022

Thank you @frenck

@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed code-quality integration: deconz smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants