Improve code quality in sql integration

[gjohansson-ST]

Proposed change

Code clean
Partly from late review comments in #68700

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[probot-home-assistant]

Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration (sql) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[bdraco]

I haven't had a moment to investigate but I did see this post today

https://community.home-assistant.io/t/2022-5-streamlining-settings/418477/438?u=bdraco

Not sure if we need to do a patch for 2022.5

[gjohansson-ST]

Tried to replicate with your patch that went into .3 and impossible so my only guess he came from one of the prior 2022.5 versions which had the issue.

[MartinHjelmare]

Thanks!

[MartinHjelmare]

Should we merge here or wait for another fix PR to avoid conflicts?

[gjohansson-ST]

Could be perhaps good to wait but not sure given we merged this in between #71532
@bdraco ?

[bdraco]

Do we want to do a change to add the missing CONF_NAME to the config entry options for the user that modified their options on .0, .1, and .2? Editing and saving the options flow also fixes it since it restores the name after the fix in .3 so it might not be worth it as it required user interaction to get it into the broken state so they likely know about the issue and have already resolved it after upgrading to .3 or by other means.

Even if we plan on doing a patch for that, I don't think it will conflict, so I think we can merge this now.

---references---

#71631 (comment)

Also the automatically created sensor from the old YAML code gives an error:
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 249, in _async_setup_platform
await asyncio.shield(task)
File "/usr/src/homeassistant/homeassistant/components/sql/sensor.py", line 97, in async_setup_entry
name: str = entry.options[CONF_NAME]
KeyError: 'name'