Skip to content

Allow RTMP sources for RTSPtoWeb#71695

Merged
balloob merged 1 commit intohome-assistant:devfrom
trvrnrth:rtmp-support
May 11, 2022
Merged

Allow RTMP sources for RTSPtoWeb#71695
balloob merged 1 commit intohome-assistant:devfrom
trvrnrth:rtmp-support

Conversation

@trvrnrth
Copy link
Contributor

@trvrnrth trvrnrth commented May 11, 2022

Proposed change

The recommended RTSPtoWeb (rtsp-to-web addon) supports RTMP sources so we now allow use of the WebRTC provider for RTMP sources.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

The recommended RTSPtoWeb (rtsp-to-web addon) supports RTMP sources so
allow use of the WebRTC provider for these.
@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (camera) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@allenporter
Copy link
Contributor

I've updated the PR description to remove the mention of the add-on since I think this is kind of out of scope of the responsibility of home assistant core. I think there are already many significant caveats mentioned in the docs about limitations and differences between the two services RTSPtoWeb and RTSPtoWebRTC that it's not necessarily worth flagging.

Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this change 👍🏼

(Can merge once CI passes)

@balloob balloob merged commit 074dfd5 into home-assistant:dev May 11, 2022
@trvrnrth trvrnrth deleted the rtmp-support branch May 12, 2022 07:00
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants