Allow RTMP sources for RTSPtoWeb#71695
Merged
balloob merged 1 commit intohome-assistant:devfrom May 11, 2022
Merged
Conversation
The recommended RTSPtoWeb (rtsp-to-web addon) supports RTMP sources so allow use of the WebRTC provider for these.
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Contributor
|
I've updated the PR description to remove the mention of the add-on since I think this is kind of out of scope of the responsibility of home assistant core. I think there are already many significant caveats mentioned in the docs about limitations and differences between the two services RTSPtoWeb and RTSPtoWebRTC that it's not necessarily worth flagging. |
allenporter
approved these changes
May 11, 2022
Contributor
allenporter
left a comment
There was a problem hiding this comment.
Thank you very much for this change 👍🏼
(Can merge once CI passes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The recommended RTSPtoWeb (rtsp-to-web addon) supports RTMP sources so we now allow use of the WebRTC provider for RTMP sources.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: