Skip to content

Bump yalexs to 1.1.25 for handling locks in "secure locked mode" as locked#71666

Merged
bdraco merged 2 commits intohome-assistant:devfrom
dacwe:patch-1
May 11, 2022
Merged

Bump yalexs to 1.1.25 for handling locks in "secure locked mode" as locked#71666
bdraco merged 2 commits intohome-assistant:devfrom
dacwe:patch-1

Conversation

@dacwe
Copy link
Copy Markdown
Contributor

@dacwe dacwe commented May 10, 2022

See Yale-Libs/yalexs@0480734

Proposed change

Some yale locks can be locked "secure mode" (cannot be unlocked from the inside). yalexs couldn't handle that in 1.1.24 but can in 1.1.25. This PR bumps the version to 1.1.25.

Comparison of the two releases: Yale-Libs/yalexs@v1.1.24...v1.1.25

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@dacwe dacwe requested a review from bdraco as a code owner May 10, 2022 23:02
@homeassistant
Copy link
Copy Markdown
Contributor

Hi @dacwe,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link
Copy Markdown

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (august) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 10, 2022

Thanks for bumping the dependency! Please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.
    This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks 👍

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 10, 2022

You'll need to run python3 -m script.gen_requirements_all in the venv or dev container to update the requirements files.

@bdraco bdraco changed the title Handling yale locks in "secure locked mode" as locked Bump yalexs to 1.1.25 for handling locks in "secure locked mode" as locked May 11, 2022
@bdraco bdraco merged commit f18d794 into home-assistant:dev May 11, 2022
@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 11, 2022

Thanks @dacwe

@dacwe
Copy link
Copy Markdown
Contributor Author

dacwe commented May 11, 2022

No problem, thanks for the help @bdraco!

@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants