Skip to content

Fix wrong brightness level change visible in UI for fibaro integration#71655

Merged
thecode merged 1 commit intohome-assistant:devfrom
rappenze:fix_dimming_in_fibaro_light
May 10, 2022
Merged

Fix wrong brightness level change visible in UI for fibaro integration#71655
thecode merged 1 commit intohome-assistant:devfrom
rappenze:fix_dimming_in_fibaro_light

Conversation

@rappenze
Copy link
Copy Markdown
Contributor

Proposed change

The brightness level had an additional jump in the UI when dimming was done over HA UI. This fixes the issue.
Reason for that jump was that in parallel brightness level was set and the device turned on.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@thecode thecode added this to the 2022.5.4 milestone May 10, 2022
@thecode thecode merged commit 2205898 into home-assistant:dev May 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2022
@rappenze rappenze deleted the fix_dimming_in_fibaro_light branch June 9, 2022 20:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lights - Brightness level is not stored?

4 participants