Skip to content

Address late QNAP QSW strict typing comments#71628

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
Noltari:qnap-qsw-strict-typing-late-comments
May 10, 2022
Merged

Address late QNAP QSW strict typing comments#71628
MartinHjelmare merged 1 commit intohome-assistant:devfrom
Noltari:qnap-qsw-strict-typing-late-comments

Conversation

@Noltari
Copy link
Copy Markdown
Contributor

@Noltari Noltari commented May 10, 2022

Proposed change

Address late QNAP QSW strict typing comments.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Copy link
Copy Markdown
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MartinHjelmare MartinHjelmare merged commit 0f41f56 into home-assistant:dev May 10, 2022
@Noltari Noltari deleted the qnap-qsw-strict-typing-late-comments branch May 10, 2022 08:29
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants