Skip to content

Improve eight sleep code quality and fix bug#71622

Merged
frenck merged 4 commits intohome-assistant:devfrom
raman325:eight
May 11, 2022
Merged

Improve eight sleep code quality and fix bug#71622
frenck merged 4 commits intohome-assistant:devfrom
raman325:eight

Conversation

@raman325
Copy link
Contributor

@raman325 raman325 commented May 10, 2022

Proposed change

The main changes were:

  • Temperature sensors now have a temperature device class and have a static unit of measurement so that HA can do the necessary conversion
  • The _get_rounded_value accepted a key as a parameter but the actual key name in the code was hard-coded. This fixes that (was inadvertently introduced in Clean up eight_sleep code #58508)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @mezz64, mind taking a look at this pull request as it has been labeled with an integration (eight_sleep) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @raman325 👍

@frenck frenck merged commit 34d4eb7 into home-assistant:dev May 11, 2022
@raman325 raman325 deleted the eight branch May 11, 2022 12:09
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants