Always show the start and stop event in logbook#71600
Merged
bdraco merged 7 commits intohome-assistant:devfrom May 9, 2022
Merged
Always show the start and stop event in logbook#71600bdraco merged 7 commits intohome-assistant:devfrom
bdraco merged 7 commits intohome-assistant:devfrom
Conversation
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
balloob
approved these changes
May 9, 2022
Member
Author
|
codecov failure is not related to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
If the stop and start event were fired within the exact same minute we would previously show it as
restartedin the logbook. When events crossed the minute boundary (i.e. we fired stop at 11:30:59 and start at 11:31:04) it would show separately asstoppedand thenstart.This change eliminates the inconstancy by always showing them as
stoppedandstartedwhich allows us to simplify how we generate logbook rows. We can now eliminate the grouping since #71331 was the other reason we had kept it.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: