Skip to content

Always show the start and stop event in logbook#71600

Merged
bdraco merged 7 commits intohome-assistant:devfrom
bdraco:logbook_cleanups_2
May 9, 2022
Merged

Always show the start and stop event in logbook#71600
bdraco merged 7 commits intohome-assistant:devfrom
bdraco:logbook_cleanups_2

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented May 9, 2022

Breaking change

If the stop and start event were fired within the exact same minute we would previously show it as restarted in the logbook. When events crossed the minute boundary (i.e. we fired stop at 11:30:59 and start at 11:31:04) it would show separately as stopped and then start.

This change eliminates the inconstancy by always showing them as stopped and started which allows us to simplify how we generate logbook rows. We can now eliminate the grouping since #71331 was the other reason we had kept it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (logbook) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Member Author

bdraco commented May 9, 2022

codecov failure is not related to this PR

@bdraco bdraco merged commit 2560d35 into home-assistant:dev May 9, 2022
@bdraco bdraco deleted the logbook_cleanups_2 branch May 9, 2022 20:21
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants