Skip to content

Improve Google Cast detection of HLS playlists#71564

Merged
emontnemery merged 1 commit intodevfrom
cast_improve_hls_detection
May 9, 2022
Merged

Improve Google Cast detection of HLS playlists#71564
emontnemery merged 1 commit intodevfrom
cast_improve_hls_detection

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented May 9, 2022

Proposed change

Improve Google Cast detection of HLS playlists by also considering the content-type.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@emontnemery emontnemery added this to the 2022.5.4 milestone May 9, 2022
@emontnemery emontnemery mentioned this pull request May 9, 2022
Closed
MartinHjelmare
MartinHjelmare approved these changes May 9, 2022
View reviewed changes
homeassistant/components/cast/helpers.py


async def _fetch_playlist(hass, url):
async def _fetch_playlist(hass, url, supported_content_types):
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add type annotations?

Copy link
Copy Markdown
Contributor Author

@emontnemery emontnemery May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but in a follow-up

@emontnemery emontnemery merged commit d284e57 into dev May 9, 2022
@emontnemery emontnemery deleted the cast_improve_hls_detection branch May 9, 2022 11:57
@emontnemery emontnemery mentioned this pull request May 9, 2022
Merged
22 tasks
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

No one assigned

Labels

bugfix by-code-owner cherry-picked cla-signed has-tests integration: cast small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2022.5.4

Development

Successfully merging this pull request may close these issues.

"Play first item in m3u and pls playlists when casting" (pull #70047) breaks playback of some playlists

4 participants

@emontnemery @MartinHjelmare @balloob @homeassistant