Skip to content

Flux_led: small fix random effects#7156

Merged
Danielhiversen merged 1 commit into
home-assistant:devfrom
Mister-Espria:fix-random-effect
Apr 18, 2017
Merged

Flux_led: small fix random effects#7156
Danielhiversen merged 1 commit into
home-assistant:devfrom
Mister-Espria:fix-random-effect

Conversation

@Mister-Espria
Copy link
Copy Markdown
Contributor

@Mister-Espria Mister-Espria commented Apr 17, 2017

Description:

Changed random.randrange(0, 255) into random.randint(0,255) so that 255 also can be a result.

Thanks to @amelchio for noticing this here.

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link
Copy Markdown

@Mister-Espria, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rytilahti, @jjensn and @Danielhiversen to be potential reviewers.

@amelchio
Copy link
Copy Markdown
Contributor

If you want to remove the wrong commits, this should push a new branch with just the last one:

git branch --move fix-random-effect bad-random-effect
git checkout dev
git checkout -b fix-random-effect
git cherry-pick bad-random-effect
git push --force origin fix-random-effect

@Mister-Espria
Copy link
Copy Markdown
Contributor Author

@amelchio Thanks it works! So next time i can fix it myself hehe.

@Danielhiversen
Copy link
Copy Markdown
Member

Thanks !

@Danielhiversen Danielhiversen merged commit 43799b8 into home-assistant:dev Apr 18, 2017
@balloob balloob mentioned this pull request Apr 21, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Jul 17, 2017
@Mister-Espria Mister-Espria deleted the fix-random-effect branch September 24, 2018 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants