Conversation
tests/helpers/test_service.py
Outdated
| """Test we set the current entity context var.""" | ||
|
|
||
| async def mock_service(entity, call): | ||
| assert entity.entity_id == service.current_entity.get() |
Member
There was a problem hiding this comment.
Should we wrap the current_entity.get call in a helper like we do for async_get_current_platform?
Member
Author
There was a problem hiding this comment.
I did that. However I made it so it doesn't raise because methods that are using it can be re-used outside of entity service calls; like media browsing can be run from a WS too (when resolving for the browser)
6ccbc84 to
9d41509
Compare
MartinHjelmare
approved these changes
May 9, 2022
Member
|
Just tested this branch with Music Assistant and it works perfectly fine. No more need for ugly workarounds to determine which player requested the media. Much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This is a proposal.
I was talking with @marcelveldt about a specific media browser use case he has with Music Assistant. His integration maintains a queue per media player, and if a song is picked in the media browser from his integration's media source he wants to add it to the queue of the entity for which it was picked.
Media sources do not have any context about who is resolving media. This PR will change that by adding a context var with the current entity ID to the function that calls entity services.
Any function called as a result from an entity service can now detect the entity.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: