Skip to content

Fix typer/click incompatibilty for unifiprotect#71555

Merged
bdraco merged 2 commits intohome-assistant:devfrom
AngellusMortis:fix-unifiprotect
May 9, 2022
Merged

Fix typer/click incompatibilty for unifiprotect#71555
bdraco merged 2 commits intohome-assistant:devfrom
AngellusMortis:fix-unifiprotect

Conversation

@AngellusMortis
Copy link
Copy Markdown
Contributor

@AngellusMortis AngellusMortis commented May 9, 2022

Proposed change

Fix so the typer<0.4.0 and click>=8.1.0 compatibility issue only surfaces if you try to use the CLI interface so the rest of the library functions without it since some users are getting the wrong mix of versions.

Changelog: https://github.com/briis/pyunifiprotect/releases/tag/v3.4.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @briis, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (unifiprotect) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco added this to the 2022.5.4 milestone May 9, 2022
@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 9, 2022

pylint failure is not related to this PR & is fixed in #71553

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 9, 2022

Test failure is in zeroconf and not related to this PR

I fixed it in #71557

@bdraco bdraco merged commit 6da8893 into home-assistant:dev May 9, 2022
@bdraco bdraco deleted the fix-unifiprotect branch May 9, 2022 02:07
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot add Unifi Protect integration after updating to 2022.5.x

4 participants