Skip to content

Fix SABnzbd config check#71549

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
shaiu:fix_sabnzbd_check_config
May 9, 2022
Merged

Fix SABnzbd config check#71549
MartinHjelmare merged 1 commit intohome-assistant:devfrom
shaiu:fix_sabnzbd_check_config

Conversation

@shaiu
Copy link
Copy Markdown
Contributor

@shaiu shaiu commented May 8, 2022

Proposed change

  1. keep old sensor keys for config check
  2. remove CONF_URL from CONFIG_SCHEMA (new) so check won't fail because it's not present in old configuration yaml

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following [Integration Quality Scale][quality-scale]:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

1. keep old sensor keys for config check
2. remove CONF_URL from CONFIG_SCHEMA (new) so check won't fail because it's not present in old configuration yaml
@MartinHjelmare MartinHjelmare merged commit 587a29c into home-assistant:dev May 9, 2022
@shaiu shaiu deleted the fix_sabnzbd_check_config branch May 9, 2022 10:41
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants