Skip to content

Ensure all mysql tables get optimized#71538

Merged
balloob merged 2 commits intohome-assistant:devfrom
bdraco:mysql_repack
May 8, 2022
Merged

Ensure all mysql tables get optimized#71538
balloob merged 2 commits intohome-assistant:devfrom
bdraco:mysql_repack

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented May 8, 2022

Proposed change

Ensure all mysql tables get optimized

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 8, 2022

Manually verified by looking at the log

		   230 Query	DELETE FROM recorder_runs WHERE recorder_runs.start < '2021-05-08 19:07:28.511945' AND recorder_runs.run_id != 1531
		   230 Query	COMMIT
		   230 Query	ROLLBACK
		   230 Query	OPTIMIZE TABLE states,state_attributes,events,event_data,recorder_runs,schema_changes,statistics,statistics_meta,statistics_runs,statistics_short_term

@bdraco bdraco marked this pull request as ready for review May 8, 2022 19:11
@bdraco bdraco requested a review from a team as a code owner May 8, 2022 19:11
@balloob balloob merged commit 6922209 into home-assistant:dev May 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants