Refactor logbook to reduce overhead and complexity#71509
Merged
balloob merged 6 commits intohome-assistant:devfrom May 9, 2022
Merged
Refactor logbook to reduce overhead and complexity#71509balloob merged 6 commits intohome-assistant:devfrom
balloob merged 6 commits intohome-assistant:devfrom
Conversation
thecode
approved these changes
May 8, 2022
Member
thecode
left a comment
There was a problem hiding this comment.
Changes for Shelly looks good
balloob
approved these changes
May 9, 2022
Member
|
Nice one!! 🐬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This may be easier to review with hide whitespace diff
Proposed change
Refactor logbook to reduce overhead and complexity
EntityAttributeCachehas been replaced withEntityNameCachesince we only ever needed it for the name as the other attributes were removed in previous PRsThe logic for augmenting context ids has been moved into
ContextAugmenterWe now only wrap
Rows withLazyEventPartialStatewhen they are needed for external events or logbook events which significantly improves performance since most entries do not require the full object. This allows the complexity of the deferral of constructing properties to be removed since we only create theLazyEventPartialStateobject when we need it.Add helpers to reduce duplication in tests.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: