Skip to content

Add timeout to update data method in Brother integration#71499

Merged
thecode merged 1 commit intohome-assistant:devfrom
bieniu:brother/add-timeout
May 7, 2022
Merged

Add timeout to update data method in Brother integration#71499
thecode merged 1 commit intohome-assistant:devfrom
bieniu:brother/add-timeout

Conversation

@bieniu
Copy link
Copy Markdown
Member

@bieniu bieniu commented May 7, 2022

Breaking change

Proposed change

This PR adds timeout to update data method.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@thecode thecode merged commit 6866cca into home-assistant:dev May 7, 2022
balloob pushed a commit that referenced this pull request May 8, 2022
@balloob balloob mentioned this pull request May 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2022
@bieniu bieniu deleted the brother/add-timeout branch September 7, 2022 13:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Brother printer integration taking 600+ seconds to start after upgrade to 2022.5

4 participants