Skip to content

Fix display of multiline queries in sql config flow#71450

Merged
balloob merged 1 commit intohome-assistant:devfrom
bdraco:fix_display_multiline_queries
May 7, 2022
Merged

Fix display of multiline queries in sql config flow#71450
balloob merged 1 commit intohome-assistant:devfrom
bdraco:fix_display_multiline_queries

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented May 6, 2022

Proposed change

Fix display of multiline queries in sql config flow

It was confusing when the query was multiline as it looked like this in the options flow:
Screen Shot 2022-05-06 at 15 12 30

After the change
Screen Shot 2022-05-06 at 15 11 18

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco bdraco added this to the 2022.5.2 milestone May 6, 2022
@bdraco bdraco requested a review from dgomes as a code owner May 6, 2022 20:14
@probot-home-assistant probot-home-assistant bot added bugfix integration: sql small-pr PRs with less than 30 lines. labels May 6, 2022
@probot-home-assistant
Copy link

Hey there @dgomes, @gjohansson-ST, mind taking a look at this pull request as it has been labeled with an integration (sql) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better

@thecode thecode modified the milestones: 2022.5.2, 2022.5.3 May 6, 2022
@balloob balloob merged commit 3883bad into home-assistant:dev May 7, 2022
@balloob balloob mentioned this pull request May 8, 2022
@teskanoo
Copy link

teskanoo commented May 8, 2022

Thanks guys

@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants