Skip to content

Move flexit climate to HVAC action#71443

Merged
balloob merged 1 commit intodevfrom
flexit-climate
May 7, 2022
Merged

Move flexit climate to HVAC action#71443
balloob merged 1 commit intodevfrom
flexit-climate

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 6, 2022

Breaking change

Proposed change

Move invalid strings for HVAC mode to use HVAC action constants.

Fixes #71440

I have not tested this change. Someone needs to verify this works.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looks ok, not tested

@jorgror
Copy link
Copy Markdown
Contributor

jorgror commented May 7, 2022

Tested and can confirm that it works as before 2022.5

@thecode thecode added this to the 2022.5.3 milestone May 7, 2022
@balloob balloob merged commit 55cb350 into dev May 7, 2022
@balloob balloob deleted the flexit-climate branch May 7, 2022 21:19
balloob added a commit that referenced this pull request May 8, 2022
@balloob balloob mentioned this pull request May 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flexit stopped working 2022.5 ValueError: 'Heating' is not a valid HVACMode

4 participants