Skip to content

Fix Insteon issue with dimmer default on level#71426

Merged
bdraco merged 9 commits intohome-assistant:devfrom
teharris1:insteon
May 9, 2022
Merged

Fix Insteon issue with dimmer default on level#71426
bdraco merged 9 commits intohome-assistant:devfrom
teharris1:insteon

Conversation

@teharris1
Copy link
Copy Markdown
Contributor

Proposed change

This fixes an issue where the default on level is not read from the device property and results in the "on" command turning the device to a brightness of zero by mistake.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅
Should this be shipped in a patch release @teharris1?

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Should we tag this for a patch release?

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 9, 2022

Oops.. Went right to the files tab and didn't see it was already reviewed!

@frenck
Copy link
Copy Markdown
Member

frenck commented May 9, 2022

Should we tag this for a patch release?

Hehe yeah had the same question 😃

@teharris1
Copy link
Copy Markdown
Contributor Author

If we can, yes. Not critical since there is a workaround but good to get out there.

@bdraco bdraco added this to the 2022.5.4 milestone May 9, 2022
@bdraco bdraco merged commit 1a45e54 into home-assistant:dev May 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2022
@teharris1 teharris1 deleted the insteon branch July 12, 2022 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants