Fix Insteon issue with dimmer default on level#71426
Merged
bdraco merged 9 commits intohome-assistant:devfrom May 9, 2022
Merged
Fix Insteon issue with dimmer default on level#71426bdraco merged 9 commits intohome-assistant:devfrom
bdraco merged 9 commits intohome-assistant:devfrom
Conversation
frenck
approved these changes
May 9, 2022
Member
frenck
left a comment
There was a problem hiding this comment.
LGTM ✅
Should this be shipped in a patch release @teharris1?
frenck
reviewed
May 9, 2022
bdraco
approved these changes
May 9, 2022
Member
bdraco
left a comment
There was a problem hiding this comment.
LGTM
Should we tag this for a patch release?
Member
|
Oops.. Went right to the files tab and didn't see it was already reviewed! |
Member
Hehe yeah had the same question 😃 |
Contributor
Author
|
If we can, yes. Not critical since there is a workaround but good to get out there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This fixes an issue where the default on level is not read from the device property and results in the "on" command turning the device to a brightness of zero by mistake.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: