Skip to content

Update Zigpy attribute cache for switch devices that do not report state#71417

Merged
Adminiuga merged 2 commits intohome-assistant:devfrom
dmulcahey:dm/zha-non-compliant-switches
May 6, 2022
Merged

Update Zigpy attribute cache for switch devices that do not report state#71417
Adminiuga merged 2 commits intohome-assistant:devfrom
dmulcahey:dm/zha-non-compliant-switches

Conversation

@dmulcahey
Copy link
Copy Markdown
Contributor

@dmulcahey dmulcahey commented May 6, 2022

Breaking change

No

Proposed change

This PR will fix an issue for non spec compliant OnOff switch / plug devices that do not report state when state changes.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@dmulcahey dmulcahey changed the title Fix Zigpy attribute cache for switch devices that do not report state Update Zigpy attribute cache for switch devices that do not report state May 6, 2022
Copy link
Copy Markdown
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Adminiuga Adminiuga merged commit 173f143 into home-assistant:dev May 6, 2022
balloob pushed a commit that referenced this pull request May 6, 2022
…ate (#71417)

* fix devices that do not report state

* whoops
@balloob balloob mentioned this pull request May 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2022
@dmulcahey dmulcahey deleted the dm/zha-non-compliant-switches branch November 11, 2022 21:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZHA Zigbee smart plug TS011F status flips back to off immediately

5 participants