Skip to content

Only lookup unknown Google Cast models once#71348

Merged
balloob merged 2 commits intodevfrom
cast_cache_unknown_models
May 5, 2022
Merged

Only lookup unknown Google Cast models once#71348
balloob merged 2 commits intodevfrom
cast_cache_unknown_models

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented May 5, 2022

Proposed change

Only lookup unknown Google Cast models via http once:

  • Fixes a problem where some TVs stutter when accessed via http
  • Prevents log spamming for devices which don't implement the http API
  • Suggest users to file an issue to add unknown models to pychromecast

Depends on a pychromecast release with home-assistant-libs/pychromecast#620

Release notes https://github.com/home-assistant-libs/pychromecast/releases/tag/12.1.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@balloob balloob marked this pull request as ready for review May 5, 2022 17:44
@balloob
Copy link
Copy Markdown
Member

balloob commented May 5, 2022

Verified tests locally.

@balloob balloob merged commit d9a7c4a into dev May 5, 2022
@balloob balloob deleted the cast_cache_unknown_models branch May 5, 2022 18:04
balloob added a commit that referenced this pull request May 5, 2022
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@balloob balloob mentioned this pull request May 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants