Skip to content

Adjust warning for missing entites#71343

Merged
frenck merged 1 commit intohome-assistant:devfrom
elupus:fix/missing_entity
May 9, 2022
Merged

Adjust warning for missing entites#71343
frenck merged 1 commit intohome-assistant:devfrom
elupus:fix/missing_entity

Conversation

@elupus
Copy link
Copy Markdown
Contributor

@elupus elupus commented May 5, 2022

It's very confusing to see this in log with no context, and the entites actually being in the entity registry.

Proposed change

Adjust log to indicate entity might have been unavailable at the time of call.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

It's very confusing to see this in log with no context, and the entites actually being in the entity registry.
@elupus elupus requested a review from a team as a code owner May 5, 2022 13:07
@probot-home-assistant probot-home-assistant bot added bugfix core small-pr PRs with less than 30 lines. labels May 5, 2022
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @elupus 👍

@frenck frenck merged commit 2dbe910 into home-assistant:dev May 9, 2022
@elupus elupus deleted the fix/missing_entity branch May 9, 2022 20:23
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cla-signed core small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants