Skip to content

Fix apple tv warning#71321

Merged
thecode merged 1 commit intodevfrom
fix-apple-play-media
May 5, 2022
Merged

Fix apple tv warning#71321
thecode merged 1 commit intodevfrom
fix-apple-play-media

Conversation

@balloob
Copy link
Member

@balloob balloob commented May 5, 2022

Breaking change

Proposed change

3 refactorings in, 1 elif was left an if. This fixes it.

Fixes #71276

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@balloob balloob added this to the 2022.5.1 milestone May 5, 2022
@probot-home-assistant
Copy link

Hey there @postlund, mind taking a look at this pull request as it has been labeled with an integration (apple_tv) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@thecode thecode merged commit a047463 into dev May 5, 2022
@thecode thecode deleted the fix-apple-play-media branch May 5, 2022 06:52
@Mariusthvdb
Copy link
Contributor

just so this is linked:#69387

balloob added a commit that referenced this pull request May 5, 2022
@balloob balloob mentioned this pull request May 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Service tts.google_translate_say is not working with AppleTV in 2022.5 beta Part 3

5 participants