Skip to content

Fix history using pre v25 queries during v26 migration#71294

Merged
frenck merged 6 commits intohome-assistant:rcfrom
bdraco:fix_recorder_trying_prev25_schema
May 4, 2022
Merged

Fix history using pre v25 queries during v26 migration#71294
frenck merged 6 commits intohome-assistant:rcfrom
bdraco:fix_recorder_trying_prev25_schema

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented May 4, 2022

Proposed change

The check was for any migration in progress and
we need to check the specific schema version
since we have another one in this version otherwise
sensors that populate from the database will get empty
data if they win the race to setup before the migration
is completed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

The check was for any migration in progress and
we need to check the specific schema version
@bdraco bdraco added this to the 2022.5.0 milestone May 4, 2022
@probot-home-assistant probot-home-assistant bot added bugfix core has-tests integration: recorder merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`. small-pr PRs with less than 30 lines. labels May 4, 2022
@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco marked this pull request as ready for review May 4, 2022 14:24
@bdraco bdraco requested a review from a team as a code owner May 4, 2022 14:24
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frenck frenck merged commit 0890f4e into home-assistant:rc May 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cherry-picked cla-signed core has-tests integration: recorder merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`. small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants