Only test for EncryptedBridge in Samsung J/H models#71291
Merged
balloob merged 2 commits intohome-assistant:devfrom May 5, 2022
Merged
Only test for EncryptedBridge in Samsung J/H models#71291balloob merged 2 commits intohome-assistant:devfrom
balloob merged 2 commits intohome-assistant:devfrom
Conversation
|
Hey there @chemelli74, mind taking a look at this pull request as it has been labeled with an integration ( |
Member
|
Tested with UN75JU641D. The tv is no longer turning off. I'm out of time to debug though |
Member
|
I think its the other problem where the token doesn't work after powering off when the session id is 1 |
Member
|
Member
|
Its still using the encrypted bridge |
Member
|
Are we solving the right problem here? Is problem that the session is expired aka the session id 1 does not survive a power off ? |
bdraco
approved these changes
May 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Only test for EncryptedBridge in Samsung J/H models
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: