Skip to content

Only test for EncryptedBridge in Samsung J/H models#71291

Merged
balloob merged 2 commits intohome-assistant:devfrom
epenet:samsung-k-model
May 5, 2022
Merged

Only test for EncryptedBridge in Samsung J/H models#71291
balloob merged 2 commits intohome-assistant:devfrom
epenet:samsung-k-model

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented May 4, 2022

Proposed change

Only test for EncryptedBridge in Samsung J/H models

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (samsungtv) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 4, 2022

Tested with UN75JU641D. The tv is no longer turning off.

I'm out of time to debug though

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 4, 2022

I think its the other problem where the token doesn't work after powering off when the session id is 1

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 4, 2022

                "data": {
                    "host": "192.168.107.76",
                    "mac": "f8:04:2e:e1:9f:18",
                    "manufacturer": "Samsung Electronics",
                    "method": "encrypted",
                    "model": "UN75JU641D",
                    "name": "Living room",
                    "port": 8000,
                    "ssdp_rendering_control_location": "http://192.168.107.76:9197/dmr",
                    "ssdp_main_tv_agent_location": "http://192.168.107.76:7677/MainTVServer2/",
                    "token": "7f86e2b4db18a675a5c6a37ef74dcaf2",
                    "session_id": "1"
                },

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 4, 2022

Its still using the encrypted bridge

2022-05-04 16:26:51 DEBUG (MainThread) [homeassistant.components.samsungtv] Create SamsungTVEncryptedBridge for 192.168.107.76
2022-05-04 16:26:53 DEBUG (MainThread) [homeassistant.components.samsungtv] Created SamsungTVEncryptedBridge for 192.168.107.76
2022-05-04 16:26:53 DEBUG (MainThread) [homeassistant.components.samsungtv] App list request is not supported on encrypted TV: 192.168.107.76

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 4, 2022

Are we solving the right problem here? Is problem that the session is expired aka the session id 1 does not survive a power off ?

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed on discord and agreed: Since websocket is the newer method it should be preferred regardless

We still need to fix the J/H models not working after power off because of session id 1, but it shouldn't block this PR

@bdraco bdraco added this to the 2022.5.1 milestone May 4, 2022
@balloob balloob merged commit db08c04 into home-assistant:dev May 5, 2022
@epenet epenet deleted the samsung-k-model branch May 5, 2022 05:25
@balloob balloob mentioned this pull request May 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants