Skip to content

Handle empty zeroconf properties in devolo_home_network#71288

Merged
frenck merged 3 commits intohome-assistant:devfrom
2Fake:hn_incomplete_query
May 4, 2022
Merged

Handle empty zeroconf properties in devolo_home_network#71288
frenck merged 3 commits intohome-assistant:devfrom
2Fake:hn_incomplete_query

Conversation

@Shutgun
Copy link
Contributor

@Shutgun Shutgun commented May 4, 2022

Proposed change

Since the last firmware update of the devolo Magic LAN devices the properties dict from the zeroconf service info can be empty. I assume it is a firmware issue, but I couldn't convince devolo, yet. Nevertheless I can handle that case to avoid exceptions in the users log. In my tests the devices could still be properly discovered and added.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @2Fake, mind taking a look at this pull request as it has been labeled with an integration (devolo_home_network) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2022.5.0 milestone May 4, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Shutgun 👍

@frenck frenck merged commit fdee880 into home-assistant:dev May 4, 2022
@Shutgun Shutgun deleted the hn_incomplete_query branch May 4, 2022 13:51
frenck pushed a commit that referenced this pull request May 4, 2022
* Handle empty zeroconf properties in devolo_home_network

* Change approach

* Restore test data
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error doing job: Task exception was never retrieved / devolo_home_network

5 participants