Skip to content

Fix meater sensor#71283

Merged
MartinHjelmare merged 4 commits intodevfrom
meater_tweak_sensor
May 4, 2022
Merged

Fix meater sensor#71283
MartinHjelmare merged 4 commits intodevfrom
meater_tweak_sensor

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented May 4, 2022

Proposed change

Correct the way in which meater keeps track of sensors which have already been added

In addition, address some minor remarks from #70669

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Sotolotl, mind taking a look at this pull request as it has been labeled with an integration (meater) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@emontnemery emontnemery mentioned this pull request May 4, 2022
22 tasks
emontnemery and others added 2 commits May 4, 2022 15:38
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 12bd5fa into dev May 4, 2022
@MartinHjelmare MartinHjelmare deleted the meater_tweak_sensor branch May 4, 2022 14:13
frenck pushed a commit that referenced this pull request May 4, 2022
* Fix meater sensor

* Cleanup MeaterEntityDescription

* Apply suggestions from code review

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Update sensor.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@emontnemery emontnemery mentioned this pull request May 5, 2022
22 tasks
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants