Add optional base64 decoding of mqtt.camera image#71223
Merged
emontnemery merged 3 commits intohome-assistant:devfrom May 9, 2022
Merged
Add optional base64 decoding of mqtt.camera image#71223emontnemery merged 3 commits intohome-assistant:devfrom
emontnemery merged 3 commits intohome-assistant:devfrom
Conversation
Add unittest for b64 decoding of camera, fix linting
Contributor
|
Hi @TheHolyRoger, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
|
Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration ( |
Contributor
|
@TheHolyRoger Thanks a lot for linking to the forum thread showing why this is a useful addition 👍 |
emontnemery
approved these changes
May 3, 2022
Contributor
There was a problem hiding this comment.
Thanks, @TheHolyRoger 👍
Can be merged when a documentation PR is opened.
Contributor
Author
|
Thanks @emontnemery ! Will do tomorrow when I get a min and will update the branch too |
Merged
9 tasks
Contributor
Author
|
@emontnemery done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The MQTT Camera integration has no support for encoded images, this PR adds optional b64 decoding
Type of change
Additional information
This PR resolves the complicated workarounds users have had to implement in order to decode b64 messages sent via MQTT and forward them on to HASS decoded, see this thread for various examples including whole nodered automations to solve this: https://community.home-assistant.io/t/blue-iris-motion-alerts-to-notification-with-image-in-home-assistant/363641/19
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
encodingconfig for mqtt camera home-assistant.io#22622If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: