Skip to content

Refactor vulcan integration#71175

Merged
MartinHjelmare merged 9 commits intohome-assistant:devfrom
Antoni-Czaplicki:vulcan-calendar-normalize
May 5, 2022
Merged

Refactor vulcan integration#71175
MartinHjelmare merged 9 commits intohome-assistant:devfrom
Antoni-Czaplicki:vulcan-calendar-normalize

Conversation

@Antoni-Czaplicki
Copy link
Copy Markdown
Contributor

@Antoni-Czaplicki Antoni-Czaplicki commented May 1, 2022

Breaking change

Migrated vulcan calendar to CalendarEntity

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • [xLocal tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Antoni-Czaplicki Antoni-Czaplicki changed the title Migrate to CalendarEntity in vulcan calendar component Refactor vulcan integration May 4, 2022
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a small comment.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit 191230f into home-assistant:dev May 5, 2022
@Antoni-Czaplicki Antoni-Czaplicki deleted the vulcan-calendar-normalize branch May 5, 2022 12:38
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants