Conversation
|
Hey there @andrey-git, mind taking a look at this pull request as it has been labeled with an integration ( |
3205f52 to
0f976fe
Compare
|
test_climate_temperature_is_none needs to be rewritten once #71149 is merged |
2b6e280 to
f6ddf10
Compare
f6ddf10 to
8f7e2f6
Compare
|
Should be good to go I hope |
| from pysensibo.model import MotionSensor, SensiboData, SensiboDevice | ||
|
|
||
| DATA_FROM_API = SensiboData( | ||
| raw={ |
There was a problem hiding this comment.
We normally put data like this in a json file in a fixtures directory for the tests of the integration. Then load the data in a pytest fixture and return it as needed.
There was a problem hiding this comment.
Alright. I do that in a new PR before I add the remaining tests.
There was a problem hiding this comment.
Rethinking: This is a dataclass coming from the upstream package where "raw" is just a minor subset to have for diagnostics.
Not sure if you mean to get the whole dataclass into a json file (seems not ideal) or just the section of "raw"?
There was a problem hiding this comment.
How you compose the fixture data into files is up to you and how the library response is built.
Proposed change
Add tests to Sensibo.
The remaining tests to be added in separate PR following this.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: