Skip to content

Add tests for Sensibo#71148

Merged
thecode merged 14 commits intohome-assistant:devfrom
gjohansson-ST:sensibo_tests
May 6, 2022
Merged

Add tests for Sensibo#71148
thecode merged 14 commits intohome-assistant:devfrom
gjohansson-ST:sensibo_tests

Conversation

@gjohansson-ST
Copy link
Copy Markdown
Member

@gjohansson-ST gjohansson-ST commented May 1, 2022

Proposed change

Add tests to Sensibo.
The remaining tests to be added in separate PR following this.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @andrey-git, mind taking a look at this pull request as it has been labeled with an integration (sensibo) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@gjohansson-ST gjohansson-ST marked this pull request as ready for review May 1, 2022 11:43
@gjohansson-ST gjohansson-ST requested a review from andrey-git as a code owner May 1, 2022 11:43
@gjohansson-ST
Copy link
Copy Markdown
Member Author

test_climate_temperature_is_none needs to be rewritten once #71149 is merged

@gjohansson-ST gjohansson-ST marked this pull request as draft May 1, 2022 16:08
@gjohansson-ST gjohansson-ST force-pushed the sensibo_tests branch 2 times, most recently from 2b6e280 to f6ddf10 Compare May 1, 2022 20:38
@gjohansson-ST gjohansson-ST marked this pull request as ready for review May 1, 2022 20:38
@gjohansson-ST
Copy link
Copy Markdown
Member Author

Should be good to go I hope

@thecode thecode merged commit 5931f65 into home-assistant:dev May 6, 2022
from pysensibo.model import MotionSensor, SensiboData, SensiboDevice

DATA_FROM_API = SensiboData(
raw={
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We normally put data like this in a json file in a fixtures directory for the tests of the integration. Then load the data in a pytest fixture and return it as needed.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. I do that in a new PR before I add the remaining tests.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rethinking: This is a dataclass coming from the upstream package where "raw" is just a minor subset to have for diagnostics.
Not sure if you mean to get the whole dataclass into a json file (seems not ideal) or just the section of "raw"?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How you compose the fixture data into files is up to you and how the library response is built.

@gjohansson-ST gjohansson-ST deleted the sensibo_tests branch May 6, 2022 08:01
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants