Migrate niko_home_control light to color_mode#70914
Merged
emontnemery merged 2 commits intodevfrom Apr 28, 2022
Merged
Conversation
epenet
reviewed
Apr 28, 2022
Comment on lines
+59
to
+60
| _attr_color_mode = ColorMode.ONOFF | ||
| _attr_supported_color_modes = {ColorMode.ONOFF} |
Contributor
There was a problem hiding this comment.
Should it not be ColorMode.BRIGHTNESS?
Contributor
Author
There was a problem hiding this comment.
Setting it to ONOFF will not change the behavior.
The non-working brightness code has been there since the integration was first added, @MartinHjelmare had review comments about it which were never addressed: #18019
Maybe @NoUseFreak or @legovaer could comment?
MartinHjelmare
approved these changes
Apr 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Migrate niko_home_control light to color_mode
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: