Skip to content

Adjust ColorMode type hint in light#70806

Merged
epenet merged 3 commits intohome-assistant:devfrom
epenet:epenet-color-mode-type-hint
Apr 27, 2022
Merged

Adjust ColorMode type hint in light#70806
epenet merged 3 commits intohome-assistant:devfrom
epenet:epenet-color-mode-type-hint

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Apr 26, 2022

Breaking change

Proposed change

Adjust ColorMode type hint in light
I bumped into an inheritance issue in #70805
Return type "Optional[Set[ColorMode]]" of "supported_color_modes" incompatible with return type "Optional[Set[Union[ColorMode, str]]]" in supertype "LightEntity"

cc @emontnemery

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (light) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@epenet

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @epenet 👍

@epenet epenet merged commit c0d8f94 into home-assistant:dev Apr 27, 2022
@epenet epenet deleted the epenet-color-mode-type-hint branch April 27, 2022 14:06
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants