Forecasts for weather underground by pezinek · Pull Request #7062 · home-assistant/core

pezinek · 2017-04-11T23:50:57Z

Description:

This PR allows forecasts for the Weather Underground component.

Related issue (if applicable): N/A

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2414

Example entry for `configuration.yaml` (if applicable):

  sensor:
  - platform: wunderground
    api_key: your_api_key
    monitored_conditions:
      - weather_1d_metric

Checklist:

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.github.io

If the code does not interact with devices:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
Tests have been added to verify that the new code works.

mention-bot · 2017-04-11T23:50:58Z

@pezinek, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tchellomello, @arsaboo and @Teagan42 to be potential reviewers.

tchellomello · 2017-04-16T21:35:44Z


-MIN_TIME_BETWEEN_UPDATES_ALERTS = timedelta(minutes=15)
-MIN_TIME_BETWEEN_UPDATES_OBSERVATION = timedelta(minutes=5)
+MIN_TIME_BETWEEN_UPDATES = timedelta(minutes=5)


@pezinek with this change, are you considering the threshold of 500 calls a day?

yes, in fact with this change all the different API requests (e.g. alerts, conditions, forecasts,... etc.) are combined into single one according to these instructions: https://www.wunderground.com/weather/api/d/docs?d=data/index#examples
So in fact this component will not do more than 288 API calls per day (for single instance)

(FIY: I'm running this code for about a 2 weeks on my home instance already, and I didn't hit the API limit)

@tchellomello are you OK with my explanation above or are there additional steps I need to do before this PR could be approved ?

rpitera · 2017-04-22T14:22:17Z

Bummed this didn't make it into the .43 release... maybe in a point release??

pezinek · 2017-05-02T20:09:30Z

Not sure what should be the next step for this PR, but please let me know if there is still something I am suposed to do in order to proceed further with this request.

Teagan42

I don't understand why you have this WUSensorConfig when almost all of those fields are available/overrideable in the Entity class

Teagan42 · 2017-05-02T22:28:45Z

+
+# Helper classes for declaring sensor configurations
+
+class WUSensorConfig(object):


Why don't you just use the entity class for these?

Hi @Teagan42, thanks for checking the code !!!
The reasons why I decided to have separate classes for storing the configuration is that the WU API is a mess and I didn't wanted to clutter the WUndergroundSensor code by all the different parsing methods for different sensor types. The second reason to have the parsing/configuration for the sensors in separate class is to allow the possibility for having multiple weather stations in the future, where multiple sensors for the same thing (with the very same configuration/parsing) will coexist in parallel, and instantiating the Entity subclasses directly in the SENSOR_TYPES list will make this much more difficult.

balloob · 2017-05-05T06:38:15Z

Okay, sorry that it took so long for anyone to take a look at your PR. This is great and I'll be down to merge it.

However, do note that we're in the process of moving all weather related sensors to the weather component with the goal that we get a nice UI in the frontend.

So it's up to you, merge this as is or migrate it to the weather component (should be pretty straight forward)

balloob

🐬

pezinek · 2017-05-05T11:59:42Z

Actually the weather component right now does have limited set of monitored conditions, so I guess it may have sense to merge this as is and later on write another separate WU component that will plug in to the new weather architecture, similarly as openweathermap components do.

rpitera · 2017-05-06T13:21:41Z

Sooo..... will this make 0.44? Asking for a friend... 😉

rpitera · 2017-05-06T19:28:56Z

Thanks very much!!

balloob · 2017-05-07T02:21:34Z

Will be included in 0.44.1 . Forgot about it for 0.44.

rpitera · 2017-05-07T11:03:35Z

No problem, man. 0.44 had a lot going on!

balloob · 2017-05-07T20:56:33Z

Cherry-picked for 0.44.1

homeassistant added platform: sensor.wunderground cla-signed labels Apr 11, 2017

pezinek mentioned this pull request Apr 11, 2017

Forecasts for weather underground home-assistant/home-assistant.io#2414

Merged

pezinek force-pushed the wu_forecasts branch from 44d9233 to 55f9c3f Compare April 12, 2017 08:04

homeassistant added the cla-signed label Apr 12, 2017

balloobbot added the platform label Apr 12, 2017

pezinek force-pushed the wu_forecasts branch from 55f9c3f to ade8fbe Compare April 12, 2017 08:08

homeassistant added the cla-signed label Apr 12, 2017

balloobbot added component core requirement labels Apr 12, 2017

Forecasts for weather underground

0c1d883

pezinek force-pushed the wu_forecasts branch from ade8fbe to 0c1d883 Compare April 12, 2017 08:18

homeassistant added the cla-signed label Apr 12, 2017

balloobbot removed the core label Apr 12, 2017

tchellomello reviewed Apr 16, 2017

View reviewed changes

Teagan42 reviewed May 2, 2017

View reviewed changes

balloob approved these changes May 5, 2017

View reviewed changes

balloob added this to the 0.44 milestone May 5, 2017

balloob merged commit 7a70496 into home-assistant:dev May 6, 2017

balloob modified the milestones: 0.44.1, 0.44 May 7, 2017

balloob pushed a commit that referenced this pull request May 7, 2017

Forecasts for weather underground (#7062)

fcdfebe

balloob mentioned this pull request May 7, 2017

0.44.1 #7482

Merged

home-assistant locked and limited conversation to collaborators Aug 12, 2017

pezinek deleted the wu_forecasts branch October 23, 2017 22:18

ghost added integration: wunderground and removed platform: sensor.wunderground labels Mar 21, 2019


		# Helper classes for declaring sensor configurations

		class WUSensorConfig(object):

Uh oh!

Conversation

pezinek commented Apr 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

mention-bot commented Apr 11, 2017

Uh oh!

tchellomello Apr 16, 2017

Choose a reason for hiding this comment

Uh oh!

pezinek Apr 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rpitera commented Apr 22, 2017

Uh oh!

pezinek commented May 2, 2017

Uh oh!

Teagan42 left a comment

Choose a reason for hiding this comment

Uh oh!

Teagan42 May 2, 2017

Choose a reason for hiding this comment

Uh oh!

pezinek May 3, 2017

Choose a reason for hiding this comment

Uh oh!

balloob commented May 5, 2017

Uh oh!

balloob left a comment

Choose a reason for hiding this comment

Uh oh!

pezinek commented May 5, 2017

Uh oh!

rpitera commented May 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rpitera commented May 6, 2017

Uh oh!

balloob commented May 7, 2017

Uh oh!

rpitera commented May 7, 2017

Uh oh!

balloob commented May 7, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

pezinek commented Apr 11, 2017 •

edited

Loading

Example entry for `configuration.yaml` (if applicable):

pezinek Apr 18, 2017 •

edited

Loading

rpitera commented May 6, 2017 •

edited

Loading