Skip to content

Use ColorMode enum in elgato #70487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 1 commit into from
Apr 24, 2022
Merged

Use ColorMode enum in elgato #70487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 13 additions & 18 deletions homeassistant/components/elgato/light.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
ATTR_BRIGHTNESS,
ATTR_COLOR_TEMP,
ATTR_HS_COLOR,
COLOR_MODE_COLOR_TEMP,
COLOR_MODE_HS,
ColorMode,
LightEntity,
)
from homeassistant.config_entries import ConfigEntry
Expand Down Expand Up @@ -78,21 +77,17 @@ def __init__(
super().__init__(client, info, mac)
CoordinatorEntity.__init__(self, coordinator)

min_mired = 143
max_mired = 344
supported_color_modes = {COLOR_MODE_COLOR_TEMP}
self._attr_min_mireds = 143
self._attr_max_mireds = 344
self._attr_name = info.display_name or info.product_name
self._attr_supported_color_modes = {ColorMode.COLOR_TEMP}
self._attr_unique_id = info.serial_number

# Elgato Light supporting color, have a different temperature range
if settings.power_on_hue is not None:
supported_color_modes = {COLOR_MODE_COLOR_TEMP, COLOR_MODE_HS}
min_mired = 153
max_mired = 285

self._attr_max_mireds = max_mired
self._attr_min_mireds = min_mired
self._attr_name = info.display_name or info.product_name
self._attr_supported_color_modes = supported_color_modes
self._attr_unique_id = info.serial_number
self._attr_supported_color_modes = {ColorMode.COLOR_TEMP, ColorMode.HS}
self._attr_min_mireds = 153
self._attr_max_mireds = 285

@property
def brightness(self) -> int | None:
Expand All @@ -108,9 +103,9 @@ def color_temp(self) -> int | None:
def color_mode(self) -> str | None:
"""Return the color mode of the light."""
if self.coordinator.data.hue is not None:
return COLOR_MODE_HS
return ColorMode.HS

return COLOR_MODE_COLOR_TEMP
return ColorMode.COLOR_TEMP

@property
def hs_color(self) -> tuple[float, float] | None:
Expand Down Expand Up @@ -151,8 +146,8 @@ async def async_turn_on(self, **kwargs: Any) -> None:
and ATTR_HS_COLOR not in kwargs
and ATTR_COLOR_TEMP not in kwargs
and self.supported_color_modes
and COLOR_MODE_HS in self.supported_color_modes
and self.color_mode == COLOR_MODE_COLOR_TEMP
and ColorMode.HS in self.supported_color_modes
and self.color_mode == ColorMode.COLOR_TEMP
):
temperature = self.color_temp

Expand Down