Add UniqueID to AsusWRT config entry#70478
Merged
balloob merged 3 commits intohome-assistant:devfrom May 3, 2022
Merged
Conversation
|
Hey there @kennedyshead, mind taking a look at this pull request as it has been labeled with an integration ( |
e8ea43d to
8624df0
Compare
8624df0 to
aedd45e
Compare
balloob
reviewed
May 2, 2022
balloob
reviewed
May 2, 2022
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Please address the comments in a new PR. Thanks!
22 tasks
Contributor
Author
|
Created follow up PR to address requests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR is to add UniqueID to AsusWRT config entry and allow configuration of multiple instance. It use as UniqueID the device Mac Address retrieved from nvram
To not break compatibility with existing configuration and in case that we are not able to retrieve mac-address from nvram, I implemented this logic in config flow:
I do not implemented any automatic migration of existing configurations because it would cause names change for existing entities.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: