Skip to content

Use Airzone WebServer MAC address as unique ID#70287

Merged
bdraco merged 12 commits intohome-assistant:devfrom
Noltari:airzone-unique-id
Apr 26, 2022
Merged

Use Airzone WebServer MAC address as unique ID#70287
bdraco merged 12 commits intohome-assistant:devfrom
Noltari:airzone-unique-id

Conversation

@Noltari
Copy link
Copy Markdown
Contributor

@Noltari Noltari commented Apr 19, 2022 •
edited
Loading

Proposed change

The latest version of the Airzone Local API now supports reporting the WebServer data, which includes the MAC address.
Use this MAC address as the unique ID on those devices that support it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Noltari
airzone: use WebServer MAC address as unique ID
1eb0739 
The latest version of the Airzone Local API now supports reporting the
WebServer data, which includes the MAC address.
Use this MAC address as the unique ID on those devices that support it.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari changed the title Use Airzone WebServer MAC address as Airzone unique ID Use Airzone WebServer MAC address as unique ID Apr 19, 2022
@Noltari
airzone: use unique ID in Airzone platforms
ca05b7b 
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
bdraco
bdraco reviewed Apr 20, 2022
View reviewed changes
bdraco
bdraco reviewed Apr 20, 2022
View reviewed changes
bdraco
bdraco requested changes Apr 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/home-assistant/core/pull/70287/files#r853874214

Please see above

Noltari added 6 commits April 20, 2022 13:09
@Noltari
airzone: add changes suggested by @bdraco
74573f9 
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari
airzone: remove confusing get_device_id function
7a9da26 
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari
airzone: remove device_id leftover
626ad12 
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari
airzone: switch to get_webserver for unique_id migration
91ba775 
Also catch possible exceptions when trying to migrate.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari
airzone: use coordinator data for unique ID migration
2e042b3 
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari
Merge remote-tracking branch 'upstream/dev' into airzone-unique-id
4d01c3b
@Noltari Noltari requested a review from bdraco April 25, 2022 12:45
bdraco
bdraco reviewed Apr 26, 2022
View reviewed changes
@Noltari Noltari requested a review from bdraco April 26, 2022 05:44
bdraco
bdraco reviewed Apr 26, 2022
View reviewed changes
Noltari and others added 2 commits April 26, 2022 09:48
@Noltari @bdraco
Update homeassistant/components/airzone/config_flow.py
fabe2d2 
Co-authored-by: J. Nick Koston <nick@koston.org>
@Noltari
airzone: fix black
5b801b8 
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari requested a review from bdraco April 26, 2022 07:56
@bdraco bdraco merged commit add7103 into home-assistant:dev Apr 26, 2022
@Noltari Noltari deleted the airzone-unique-id branch April 26, 2022 08:53
@Noltari
Copy link
Copy Markdown
Contributor Author

Noltari commented Apr 26, 2022

Thanks @bdraco! 🎉

@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2022
MartinHjelmare
MartinHjelmare reviewed May 5, 2022
View reviewed changes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@bdraco bdraco bdraco approved these changes

Assignees

No one assigned

Labels

by-code-owner cla-signed code-quality has-tests integration: airzone small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Noltari @bdraco @MartinHjelmare @homeassistant